Tests | Split MultipleResultsTest, clean up console logging #3060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adjusted certificate generation, it's redirecting standard errors and not always loading the user profile.
mdaigle
approved these changes
Feb 18, 2025
| Assert.Equal(authProvider, SqlAuthenticationProvider.GetProvider(SqlAuthenticationMethod.ActiveDirectoryDeviceCodeFlow)); | ||
| } | ||
|
|
||
| private Task CustomDeviceFlowCallback(DeviceCodeResult result) |
There was a problem hiding this comment.
It would help readability if we remove this method. It's not doing anything useful now that the logging is removed.
There was a problem hiding this comment.
Thanks, I've removed it. Can you trigger another CI run please?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3060 +/- ##
==========================================
- Coverage 72.81% 66.21% -6.61%
==========================================
Files 282 276 -6
Lines 59112 58802 -310
==========================================
- Hits 43045 38933 -4112
- Misses 16067 19869 +3802
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benrr101
approved these changes
Feb 20, 2025
...Data.SqlClient/tests/ManualTests/ProviderAgnostic/MultipleResultsTest/MultipleResultsTest.cs
Outdated
Show resolved
Hide resolved
...Data.SqlClient/tests/ManualTests/ProviderAgnostic/MultipleResultsTest/MultipleResultsTest.cs
Outdated
Show resolved
Hide resolved
...Data.SqlClient/tests/ManualTests/ProviderAgnostic/MultipleResultsTest/MultipleResultsTest.cs
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 25, 2025
Open
This was referenced Oct 13, 2025
This was referenced Oct 20, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts to adjust the way the SqlClient tests use the console stdout. It contains two changes.
MultipleResultsTest rework
This was one large method. It would temporarily replace the console stdout, log to it, then manually perform a diff between the stdout and a file bundled with the project.
I've modified this, splitting the large method into three tests (ExecuteNonQuery, ExecuteReader, ExecuteScalar.) These tests are designed to prove the way that SqlClient handles informational messages, exceptions and result sets when MARS is enabled.
Console stdout rework
I've noticed a few instances where standard output from the TDS servers get mixed in with the test results logged in the CI pipeline. This output isn't useful, even when the tests fail; I've disabled it in a few areas.